This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Export archive #432
Merged
Export archive #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| t = Time.new.utc.strftime("%Y%m%d%H%M%S") | ||
| Dir.mktmpdir("chefdk-export-#{p}-#{t}") do |d| | ||
| begin | ||
| @staging_dir = d |
There was a problem hiding this comment.
Could you just yield staging_dir?
There was a problem hiding this comment.
Lemme see how many places I'll have to thread it around.
There was a problem hiding this comment.
I looked into it and it made everything a lot uglier. In this case I don't think it's that big a deal since everything that depends on staging_dir is private, so there's no way to call a public method where it would fail because of staging_dir being nil. Thoughts?
|
👍 |
Adds dependency on `minitar` which is dual licensed as GPL or "same terms as Ruby"; Ruby is multi-licensed with one option being 2-clause BSD.
danielsdeleo
force-pushed
the
export-archive
branch
from
8961e1b to
0bf9f9c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag to
chef exportso you can export a tarball instead of just the plain directory structure. This is to support a futurechef push-archivecommand that can be used to transfer policyfiles and the relevant code to an environment with limited networking access.